remove the security.listener.factory DIC tag #2585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 2, 2013
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.1+ |
| Fixed tickets | #2347 |
|
we maybe can add a versionadded directive stating that this is removed. @weaverryan wdyt? |
weaverryan
added a commit
that referenced
this pull request
May 4, 2013
…-dic-tag remove the security.listener.factory DIC tag
|
Thanks for the good PR! @wouterj - If 2.1 were the current version, then I'd agree with you that we should add a note. We'd then remove that note on the 2.3 branch later on (like we recently did with other 2.1 notes). In this case, I think we can avoid doing the extra work of having this note on just the 2.1 and 2.2 branch since this is all already in the past. So, we'll save a little trouble :). Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.